Jelte Fennema-Nio

Results 698 comments of Jelte Fennema-Nio

Nothing fancy, just the ouptut of DuckDB it's EXPLAIN (FORMAT JSON) embedded into the `DuckDB Execution Plan` node. Now it embeds the text version. For example this query: ``` explain...

> 1.Should the Output Format Controlled via an Enum GUC? No, it should be controlled by the explain format. So `EXPLAIN (format JSON) ...` should always use the json formatting....

Looks great! The only nitpicks I would have are: 1. the number of spaces used for indentation is different, but I expect that's not configurable in duckdb, so that would...

> The intention here was to use the JSON data to format the explain plan to look like Postgres explain plans, rather than use the DuckDB formatting. That sounds cool,...

Actually do you mean to have even the TEXT format to look more like postgres? If so, that sounds even cooler. But for now it seems nice to at least...

I think because the title included JSON I assumed it was about `(format json)` even though it didn't say that anywhere in the description. So updated the title to make...

@pantonis cloudflare implements the S3 API. So support is basically free once we implemented S3 support. Azure support requires a little bit more work, due to the API differences.

No promises, but I think it would be surprising if this feature does not make the cut for 0.2.0. Feel free to contribute a PR btw.

Fixed by #478 (which will be released in the 0.2.0 release that's planned for next week). If certain behavior is not working please report that as a new issue.

@Tishj this is fixed now right? If so, let's close it.