thebeat
thebeat copied to clipboard
Jellevanderwerff
thebeat: Rhythms in Python for science
The 'plot phase differences example' in the documentation needs some work, with examples of how this works with anisochronous sequences, some explanation of what phase differences are, etc.
See: - https://computational-audition.gitlab.io/repp/signal_processing/onset_alignment.html - https://gitlab.com/computational-audition/repp/-/blob/master/repp/analysis.py?ref_type=heads Proof of concept with some NumPy broadcasting magic: ```py import numpy as np ref_onsets = np.array([500, 1500, 2000, 3000]) ref_iois = np.diff(ref_onsets) test_onsets = np.array([-100,...
The current default style for all plots is some old, deprecated version of seaborn's style, through matplotlib. This does not seem correct or extandable. If I apply my own style...
Instead of creating a new class ``MultiRhythm`` (or something), start with creating a simple function for plotting multiple rhythms. Reasonig: In principle, it is already possible to overlay ``SoundSequence`` objects...
Another option would be to cache a list of all the combinations of different Rhythms.
E.g. for ``thebeat.stats.get_ugof_isochronous``, the expected return type is np.float64, even though the function returns np.float32.
Sometimes input validation is done using e.g. ``isinstance(input, (int, float, np.float64))`` etc. Better change this to use the numbers module, e.g. ``isinstance(input, Integral)``
TODO: Go over warnings/errors and fix them one by one until tests turn green
TODO: Fix and shorten docstring line lengths, until all tests pass