thebeat icon indicating copy to clipboard operation
thebeat copied to clipboard

thebeat.helpers.sequence_to_binary should return integers

Open Jellevanderwerff opened this issue 1 year ago • 3 comments

Jellevanderwerff avatar Aug 29 '23 09:08 Jellevanderwerff

Used to return floats. Now, integers. In the future, booleans.

Jellevanderwerff avatar Sep 07 '23 10:09 Jellevanderwerff

Done in 0678916835579450d87f3dee96840c9bbf6ac62f

The function now returns booleans, but we should check all usage. Convolving or cross-correlating two boolean arrays returns another boolean array. Very likely not what we want in most cases. Is this reason enough to use ints?

YannickJadoul avatar Sep 07 '23 21:09 YannickJadoul

Reverted in ac141e5d05f75b4d0e7cba67c10fcab2f0386fbe

YannickJadoul avatar Sep 07 '23 21:09 YannickJadoul