Jelle Zijlstra

Results 643 comments of Jelle Zijlstra

Grep for `xfail` in the mypy sourcecode and you'll see.

Are you sure this isn't a bug in the Django plugin? It is developed independently from mypy itself.

Some of the traceback (from mypy-play): ``` File "/layers/google.python.pip/pip/lib/python3.12/site-packages/mypy/checker.py", line 5107, in visit_match_stmt pattern_types = [self.pattern_checker.accept(p, subject_type) for p in s.patterns] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/layers/google.python.pip/pip/lib/python3.12/site-packages/mypy/checkpattern.py", line 129, in accept result =...

This is reproducible without the Callable too: https://mypy-play.net/?mypy=latest&python=3.12&gist=5c01688fc2c9bd27d67d69ea6b292f94&flags=warn-unreachable ```python from typing import Literal from typing_extensions import assert_never def doit_if(result: Literal[1, -1]) -> None: if result == 1: pass elif result...

> (I would like to get comfortable with mypy's internals and start fixing bugs rather than just reporting them, but I'm not really sure where to start.) I think few...

The bokeh hit looks unavoidable, the variable is assigned different types in two branches and mypy generally doesn't like that. I suspect the ibis hit is because mypy thinks we...

Tests are failing, I think because the `*Ts` syntax is 3.12 only. Maybe split that part of the test into its own case and make it run `--python-version 3.12`.

Thanks for the review! I applied the suggestions, and will deal with the larger issues in the next few days.

Thanks @sobolevn! I have pushed some changes to address your review.

Thanks! I'll work on a separate PR with incremental tests for both TypeGuard and TypeIs.