mypy icon indicating copy to clipboard operation
mypy copied to clipboard
verified publisher icon python

Add test documenting #12998

Open tamird opened this issue 1 year ago • 1 comments

Add a test demonstrating #12998.

tamird avatar Apr 30 '24 15:04 tamird

@hauntsaninja

tamird avatar Apr 30 '24 15:04 tamird

@hauntsaninja would you mind taking a look?

tamird avatar May 09 '24 13:05 tamird

I'm not Shantanu but I don't think we should add a test that's testing incorrect behavior. Maybe make it an xfail test with the desired behavior.

JelleZijlstra avatar May 09 '24 15:05 JelleZijlstra

How do I make it xfail? mypy seems to have a bespoke testing framework.

tamird avatar May 09 '24 15:05 tamird

Grep for xfail in the mypy sourcecode and you'll see.

JelleZijlstra avatar May 09 '24 15:05 JelleZijlstra

Done, thanks.

tamird avatar May 09 '24 16:05 tamird

@JelleZijlstra anything further?

tamird avatar May 09 '24 19:05 tamird

Ping. Can we merge this please?

tamird avatar May 13 '24 17:05 tamird

It's on my list of pending reviews, so I will get to it.

However, the repeated pings feel very strange to me. Why is it important to you that we merge a change that just adds a failing test?

JelleZijlstra avatar May 13 '24 17:05 JelleZijlstra

It's more important that #17230 is acknowledged certainly. Apologies for the nuisance.

tamird avatar May 13 '24 18:05 tamird