Jeffrey Vo

Results 28 comments of Jeffrey Vo

I'm currently working on this, but I wanted to gather opinions on how to properly tackle this, especially in regards to how much backward compatibility (if any) we should strive...

> I think a key requirement is that sqlparser continues to be able to parse queries it is currently able to (doens't start rejecting queries it used to parse) This...

I plan to take this on, probably starting first with `COPY TO`

> > Instead of adding/modifying as described, could investigate ways to make it easier for downstream consumers to parse their own custom statements. > > I think this would be...

Will need more info on this to reproduce, as `\"` seems to parse just fine within a literal, e.g. ```sql SELECT '\"test\"' ```

Actually I think I was off the mark on what `ExprId` is intended to do, it seems it would be more useful if there were a new LogicalExpr enum such...

> I think the idea of skipping N rows on the file level doesn't make much sense. What we can probably do is to skip N rows on dataframe level,...

Duplicated by https://github.com/sqlparser-rs/sqlparser-rs/issues/770, can check that for answer

seems resolved by https://github.com/sqlparser-rs/sqlparser-rs/pull/441 and https://github.com/sqlparser-rs/sqlparser-rs/pull/446

For datafusion, the issue came from https://github.com/apache/arrow-datafusion/issues/8743 Tagging @ted-jiang who reproduced the issue An example of the dependency datafusion has: https://github.com/apache/arrow-datafusion/blob/e7cc04db68a05ce9d002de7d0c1be2644bf69c0c/datafusion/common/Cargo.toml#L41-L43 - Located in a few other crates within datafusion...