Jeffrey Vo

Results 53 comments of Jeffrey Vo

Some pointers. Planner code here, need to wire in support for operators other than `=`: https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/functions-nested/src/planner.rs#L124-L136 Implementation in here: https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/functions-nested/src/array_has.rs - Need to consider how to work it into the...

Hey @NiwakaDev just checking in if you're still working on this; otherwise I'll remove the assignment to free it up

Some pointers: Planner code here, need to wire in support for `AllOp` node: https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/sql/src/expr/mod.rs#L632-L635 See how `AnyOp` is handled: https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/sql/src/expr/mod.rs#L590-L622 See implementation for `ArrayHasAll` which can be used (at least...

Thanks for the detailed investigation @feniljain You're right in that it seems `ArrayHasAll` doesn't seem to be usable out of the box as I initially thought. It seems `ArrayHasAll` is...

Actually thinking about it more, perhaps this is related to: - https://github.com/apache/datafusion/issues/2548 In that these SQLs are equivalent: ```sql SELECT 1 = ALL(ARRAY[1,1,1,1]); SELECT NOT (1 ANY(ARRAY[1,2,3,4])) ``` So maybe...

> If there is a good way to deal with the mentioned feature flag issue, I think we should add this lint rule. It would look something like this: ```rust...

I've marked it as good first issue, but note to anyone interested, please do not assign this issue to yourself as it is meant to be a tracking issue. Just...

> [@Jefffrey](https://github.com/Jefffrey), for `datafusion-functions-nested` it suffices to add `#![deny(clippy::allow_attributes)]` as there is no usage of `#[allow]`. The same applies to `datafusion-functions-table`. If it's ok, I'll create a PR to enforce...

> I would like to raise the fact that warn also does work for this case, so if there is specific need, you might also resort to it. I think...