Alessandro Lai

Results 270 comments of Alessandro Lai

A PR is more than welcome, but I would suggest you to split it in multiple ones, since it looks like your fork is mixing multiple new features in a...

@cooperaj you can fix that by changing the CI under the `include` key: there's a specific job for the `--prefer-lowest` case, were 7.4 is specified; you should bump it to...

Closing and reopening to trigger actions, it got disabled.

CI was disabled due to inactivity, I re-enabled it. I'll close & reopen this PR to trigger a new CI run.

I'm sorry but the upstream IS tagged and released since long ago: https://github.com/facile-it/php-jose-verifier/releases/tag/0.5.0-beta1 If you can complete this PR, we can push together and tag stable release there and here...

Static analysis is failing due to `prophecy-phpunit` not being ready yet, so I also opened https://github.com/phpspec/prophecy-phpunit/pull/67 Tests are running only on PHPUnit 9 though :( we should change that

@alexander-schranz since it's a require-dev, I took the liberty of adding a workaround for this. Are you ok with merging it in this way?

@alexander-schranz done in #386

Ok I renamed my first commit (since it addressed only variables named `$mapping`) and added a second one for `$fieldMapping`. I'll proceed to add more stuff.

Ok that's all for me. Let me know if there are more ways to fetch the FieldMapping object that I should inspect.