phpstan-prophecy icon indicating copy to clipboard operation
phpstan-prophecy copied to clipboard
verified publisher icon Jan0707

Allow PHPUnit 12

Open Jean85 opened this issue 10 months ago • 1 comments

This pull request

  • [x] Allow this package to work with PHPUnit 12

This is a tentative PR to see if we can just widen the constraint, or if we need to do more work.

Jean85 avatar Feb 07 '25 09:02 Jean85

Static analysis is failing due to prophecy-phpunit not being ready yet, so I also opened https://github.com/phpspec/prophecy-phpunit/pull/67

Tests are running only on PHPUnit 9 though :( we should change that

Jean85 avatar Feb 07 '25 09:02 Jean85

looks like we need to wait for the phpspec/prophecy-phpunit release tag. /cc @stof anything planned?

alexander-schranz avatar May 14 '25 11:05 alexander-schranz

@alexander-schranz since it's a require-dev, I took the liberty of adding a workaround for this. Are you ok with merging it in this way?

Jean85 avatar May 19 '25 11:05 Jean85

@Jean85 I'm fine to merge it but not tag it would before tagging revert the master and specially reactivate composer strict linting, when phpunity-prophecy is tagged. Can you open a PR with reverting that parts?

alexander-schranz avatar May 20 '25 06:05 alexander-schranz

@alexander-schranz done in #386

Jean85 avatar May 20 '25 06:05 Jean85

@Jean85 thank you! @stof feel free to ping me when prophecy-phpunit is released.

alexander-schranz avatar May 20 '25 06:05 alexander-schranz