Steve Schwartz

Results 147 comments of Steve Schwartz

I deleted the change to rails.js and just kept the test, ran it in Chrome, Firefox, Safari, and IE9, and the test passed on all. What browser were you running...

@lukeseelenbinder no need to resubmit a pull request. If you make the changes and add a test case, you can force push to your branch and it will update this...

`.stopEverything()` gets called for `a['data-confirm']` elements [on line 302](https://github.com/rails/jquery-ujs/blob/master/src/rails.js#L302). The test should go [in the test/data-confirm.js file](https://github.com/rails/jquery-ujs/blob/master/test/public/test/data-confirm.js).

Can someone clarify for me what exactly we're talking about changing in jquery-ujs in this issue? I don't think I quite understand. For what it's worth, I know it's not...

Got it. So you actually don't want it to change the text at all, you just want it to disable the button without modifying the text. I think rather than...

To clarify further on my previous point, it's not the `data-some-attribute=true` that causes issues, as the string `"true"` will evaluate to true in JS anyway. It's when someone wants `data-some-attribute=false`...

@simsalabim You're right. My example is incorrect. I guess I can't distill the issue down as much as I was trying. The full issue is with: 1. ``` ``` 2....

Yeah, sorry, I'm writing a response. Just got really busy.

I've tried a few more things to see if I could fix it but with no luck. I've replaced [this line](https://github.com/RailsApps/rails_apps_composer/blob/master/recipes/extras.rb#L44) with the following (to try switching gemsets a few...

Finally figured out what's causing this (though I'm still not sure why, as it seems like it should work anyway). It's due to trying to run the rails new my_app...