Steve Schwartz

Results 147 comments of Steve Schwartz

I'm honestly not sure what the best solution here would be. I can see your point for copying the `data-` attributes over to the form. However, it's one of those...

For now, I'm going to mark this as a potential future enhancement. I'm not opposed to adding AMD support, but I'm cautiously skeptical. The issues with adding AMD support are...

I'm not completely against namespacing the data attributes, to be honest. But it would be something that'd have to be coordinated with the back-end team, since we'd need to change...

If I understand correctly, the collisions you were referring to weren't with if you specify the same data attribute multiple times in your ruby helper, but rather potential collisions with...

Interesting. Pretty simple fix. Can anyone come up with a test case for this? If not, we can, it'll just take longer to pull this in.

Closing as it's a duplicate of #213 (pull request).

#213 still needs a test case, which I haven't had time to write yet.

Closing this and reopening #213, since it has a pull request.

Reopening this for now, because the pull request (and the code suggested here) is not the correct implementation for the feature being requested. At first I was going to say...

For what it's worth, if anyone comes across this, there is a way you can have remote buttons without modifying jquery-ujs. Include this javascript before including jquery-ujs: ``` js $(document).bind('rails:attachBindings',...