Steve Schwartz

Results 147 comments of Steve Schwartz

@KeithHenry Yeah, I should have glanced at the source. Not sure I see the difficulty in checking support of the hack though. Looking through it, it's not incredibly complicated. I'm...

For what it's worth, [here's how jQuery 1.8 detected msie](https://github.com/jquery/jquery/blob/1.8-stable/src/deprecated.js#L15). We could just re-implement this: ``` js var ieMatch = /(msie) ([\w.]+)/.exec(navigator.userAgent), ieVersion = ieMatch && ieMatch[2]; ```

@konsumer Agreed, but it from what others are saying here, this is a separate check from the hashchange support check. They're saying that the issue is with older IE browsers...

@konsumer I'm confused as to what you're suggesting. `document.documentMode` is already being used in the check for supporting hashchange. We're not talking about that. We're talking about checking the browser...

@KeithHenry Completely agreed, which is why I was suggesting explicitly checking for those browsers if needed. By using something like a random `boxModel` check, it's not clear what the intention...

Hmm, I'll try it. My initial guess is there may be some race condition in the spec itself (I had issues sometimes even with Firefox where specs would occasionally fail...

Thanks @jnimety, I appreciate the test case. However, the reason you are getting a javascript response is because the form doesn't have `data-type="json"`. This is not an issue with remotipart,...

I have no idea to be honest. It might be a difference in the way that rails ActionDispatch handles xhr and normal requests differently (i.e. maybe it treats the extension...

It sets it to _prefer_ script [on this line](https://github.com/JangoSteve/remotipart/blob/master/vendor/assets/javascripts/jquery.remotipart.js#L45) if no data type is defined (that asterisk means script and then everything else). It does this, because it's what jquery-ujs...

Forgot to mention, it should only be preferring script, not requesting it as the only format. If your action only has a json response type, then that should be what's...