Results 173 comments of Jan Krivanek

@AArnott - are you still hitting this? I wasn't able to repro on 7.0.3xx: ``` > dotnet --version 7.0.300-preview.23179.2 > upgrade-assistant analyze .\ConsoleApp6.sln ----------------------------------------------------------------------------------------------------------------- Microsoft .NET Upgrade Assistant v0.4.421302+be0ea11e8234f2a0bde2d170b0fdd455fa4f9a45 We...

More involved and 'unattended' solution might be to check if the extension is reconginzed as textual, if not attempt to autodetect the format of the file (more on that e.g....

> Looks great. I guess adding more special-case handling of the `restore` target should boost the priority of #9553. 100% agree on we should add mechanism flagging that issue. Though...

> I wonder if in this case we could get away with adding a high-importance message right to `XMake.cs` (as opposed to building an analyzer). I support that! It wouldn't...

Looks like another case of https://github.com/dotnet/project-system/issues/9001

> I like the idea of having a full-strength end-to-end-via-package test, but it feels very early for that to be checked in, and the package construction stuff is low-pri for...

Rereview https://github.com/dotnet/msbuild/pull/9735#discussion_r1557537364

> Thank you for the quick review. > > > Btw. - don't you want to extend the TaskParameterEventArgs as part of this PR? If not - would be nice...

Or probably better apprach - add it as part of each MSBuild invocation in arcade: https://github.com/dotnet/arcade/blob/0f16479e1811ef3b5c9fc251563c6181f9083c34/eng/common/tools.ps1#L795

Prerequisity: https://github.com/dotnet/sdk/issues/28915