Jan Krivanek

It's rather a personal opinion based on limited experience - so let me update the description to make it clear. Tha being said - those were my thoughts: * We...

Team decision: * Let's use MicroBuild as it should be less invasive and less complicated way to onboard APIScan * Should some major complications arise during the work - let's...

FYI @baronfel Thank you @jrdodds for a nice suggestion. The strong type system is not yet on the top of MSBuild team priority list (though it's something that was discussed...

@maridematte pls check if this is caused by same problem or unrelated: https://github.com/KirillOsenkov/MSBuildStructuredLog/issues/762

Or could we reconstruct the initial targets from the `BuildRequestEntry` passed to that method? (`entry.RequestConfiguration.ProjectInitialTargets`) That should not require any contract change.

Btw. is the `AfterTargets` BuildReason populated as well? I'm wondering whether the https://github.com/KirillOsenkov/MSBuildStructuredLog/issues/762 is an MSBuild issue or Viewer issue.

The reasoning and fix looks good to me. There are some failing tests related to the AfteTargets - let's see if we can nail those as well

In msbuild we have just the single usage being fixed. There are couple similar usages in Blazor targets in sdk: https://github.com/search?q=repo%3Adotnet%2Fsdk+path%3A**%2F*.targets+substring&type=code Once the fix is inserted we should reach out...

Handled in scope of https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/2031987/?view=edit

Only slightly - it slashes only about a third of currently detected slowdown of the analyzers. Though the detected slowdown was in range of about 14% - so it's puzzling...