Jan Krivanek
Another incidence (after the timeout increasing): https://dev.azure.com/dnceng-public/public/_build/results?buildId=681320&view=ms.vss-test-web.build-test-results-tab&runId=16909114&resultId=100003&paneView=debug
Might be totally red herring: The timeouting cases seem to have TerminalLogger used (notice the control sequences): ``` [33;1m Microsoft.Build.BuildCheck.UnitTests: [Long Running Test] 'Microsoft.Build.BuildCheck.UnitTests.EndToEndTests.SampleAnalyzerIntegrationTest', Elapsed: 00:01:02 [mExecuting [/home/vsts/work/1/s/.dotnet/dotnet /home/vsts/work/1/s/artifacts/bin/bootstrap/net8.0/MSBuild/MSBuild.dll FooBar.csproj...
Perfect! Can you collect 2 more cases to see if there is any pattern? Plus appart from the diag log it might be helpfull to have binlog as well. Other...
Yeah - the binlog being cut aburptly is fine (and expected as test is killed after timeout) - the timeline from binlog will be interresting - it should show where...
From offline discussion Observations: * The repros seem to indicate that the test will get stuck in the same place - during [`_GenerateRestoreProjectPathWalk`](https://github.com/dotnet/dotnet/blob/91ab1b9027707137f2fd2f0541c9f2d23e958a29/src/nuget-client/src/NuGet.Core/NuGet.Build.Tasks/NuGet.targets#L1250) execution (which is invoked from restore) -...
Fixed by https://github.com/dotnet/msbuild/pull/10353
> How about self-concatenation: > > ``` > > $(DefineConstants);DEBUG > > ``` Ideally that should be excluded as well... but depends on the way we go about implementing this....
Btw. this might be something that we might want to ship as message severity (or even disabled) in initial versions. It seems to be quite common pattern where custom scripts...
Oh I missed the part about allowing conditions - sorry. Yeah - it makes it much more usefull (as well as bit more challenging to implement :-))
> Prior art here is > > https://github.com/dotnet/msbuild/blob/7adbbc162c3d9f37d8b287dd03f637b1831441fa/src/Build/Evaluation/Expander.cs#L372-L376 > > (and it may be enough to just use that, changing the severity of the event it fires) Playing with this...