Jan Krivanek
Jan Krivanek
Applogies - I accidentaly didn't respond. @AArnott - this is 'by design' for msbuild in a sense that the property parameter is not being passed to msbuild execution from sdk...
https://github.com/dotnet/sdk/issues/43355
@AArnott - appologies - oversight on my side (I didn't notice orriginal issue was separate from the endo of discussion) @JaynieBai - can you please look once again and elaborate...
@hknielsen Is it possible that you are reusing ProjectCollection after it was Disposed or after getting exception during construction? Those are the only two cases where the LoggingService initialized in...
Thank you for filing high quality bug! It seems we are missing on opportunity to emit better error somewhere here: https://github.com/dotnet/msbuild/blob/d0a797e9ed0d218bcae30a986b9e14ed56339460/src/Tasks/XamlTaskFactory/XamlTaskFactory.cs#L186
> Can you write up some motivation for doing it with extension methods, and what an old/new calling pattern would be? @rainersigwald I've added a motivation + sample to the...
> > The discussed code would change to: > > ```cs > > foreach ((string itemType, IItemData itemValue) tuple in projectEvaluationFinishedEventArgs > > .EnumerateItems() > > .Where(i => i.itemType.Equals(ProjectReferencePropertyName))) >...
> > > The discussed code would change to: > > > ```cs > > > foreach ((string itemType, IItemData itemValue) tuple in projectEvaluationFinishedEventArgs > > > .EnumerateItems() > >...
> @JanKrivanek How did you generate these tests? @Janek91 - Research project :-)
> I know you said not to review, but I would be more than happy to just merge this 😁 ~100%~ 1000%! :-) Though there is quite some process around...