Results 173 comments of Jan Krivanek

The addition to the binlog might be bundled with `BuildCheckTracingEventArgs` de/serialization - in order to minimize formats bumps

Suggested location to publish the event: https://github.com/dotnet/msbuild/blob/06bb1c233fd4f2cd136ba3bbbfcb4b553a2eceb6/src/Build/BackEnd/BuildManager/BuildManager.cs#L1378

(not maintained here - moved to ticket description) ----------------------- Course of action: * [ ] Update public documentation to make the fate very clear: @maridematte, sample: https://github.com/dotnet/msbuild/pull/10166 * [ ]...

To deliver the message ASAP it's easier to follow the lowest risk path (so no breaking changes). We can possibly add Obsolete attributes after the docs are updated. It all...

Synced with @AR-May on this - our conclusion: The root of the problem is in our custom implementation of FileExists (`FileExistsWindows`). The suggested course of action (@JaynieBai): * Compare performance...

Thanks @MichalPavlik! We should probably file a bug with Runtime team. I'm wondering how does this allocation influence overall build perf. @JaynieBai - can you run OrchardCore build with current...

I have no strong preference between the 2 (`MS.IO.Redist` vs `System.IO`) - but I'm definitely in favor of getting rid the custom implementation.

Goot catch and analysis! Apparently the `BuildEventContext` is currently good for logging only in the node that created it via `LogProjectStarted` - as that's the only place where the `_projectFileMap`...

I have a bit mixed feeling about this - is there a chance that this negatively impacts some of the current scenarios? Do we know what's the usual initial delay...

Team is not ready to take this as adaptive timeout can cause other regressions