Jan

Results 273 comments of Jan

having had a bit to think about this, what about when a tag and branch are both on the same commit? I think it would be better to generally look...

right, ignore me forgetting to run black I've changed the approach to the one you suggested: checking if the branch exists before updating. This is implemented in a naive way...

Now with the complete move to x86_64 I found out that Lua fails to build, so some more work needs to be done before this can be merged.

Problem with Lua not building on x86_64 is fixed by #15461, package script was changed as suggested

> Just tried it to be sure, didn't work. the release was created a few weeks ago but the tag had been changed 4 days ago, resulting in hash checks...

> Doesn't build, incorrect `workdir` (as we now download by the commit hash, not by the tag name). > > Please test-build your changes at the very least. Apologies for...

I think it would be better to work with the Modrinth people to figure out a solution that could also be implemented by other launchers. Right now the curseforge scheme...

Here are some extra attributes that I think are worth considering: - `required_plugins` a list of plugins required to function - `hidden` tells a plugin managers to not show this...

Manged to get it working while working on #53 #53 could be completed once I know the names of the processes

![image](https://user-images.githubusercontent.com/15076013/150643187-39138204-f174-461f-80fe-2bffd440b8ed.png) its now in a working state again