serenity
serenity copied to clipboard
SerenityOS
Ports: Add Lite-XL
Startup is a bit long but this is a problem with Lite-XL, not the port itself.
Now with the complete move to x86_64 I found out that Lua fails to build, so some more work needs to be done before this can be merged.
Problem with Lua not building on x86_64 is fixed by #15461, package script was changed as suggested
Just tried it to be sure, didn't work.
the release was created a few weeks ago but the tag had been changed 4 days ago, resulting in hash checks failing.
Using the prior release is undesirable because its missing many improvements, uses a directory monitoring library that isn't easily adapted for SerenityOS and depends on a prior release of Lua, which Serenity does not ship.
I'll go check with the upstream maintainers what the best way to proceed is and might outright switch to a commit to ensure this doesn't happen again.
Yeah, feel free to point to the latest commit for now, but please tell upstream that changing a release after the fact is bad practice. :sweat_smile:
Doesn't build, incorrect
workdir(as we now download by the commit hash, not by the tag name).Please test-build your changes at the very least.
Apologies for that I've rushed out the change without proper testing.
I've now tested and found that the patch that adds SerenityOS support was borked because of a change in the dirmonitor API introduced on the master branch, which is now resolved and tested.
If you fail to build the port #15434 may fix it for you.