Jamie Magee comments

Results 253 comments of


                                            Jamie Magee

Refactor: Fix 1216

There's a lot of trailing whitespace issues. Can you fix those please?

Rust detector silently discards non-dev dependencies when `Cargo.toml` file contains dependency from git

I had a chat with @ByAgenT about this offline. The fix is to add another `else if` to this if/else statement to handle git dependencies: https://github.com/microsoft/component-detection/blob/cc5c5ffd7fa528953f24c4962a3ea7506698aa86/src/Microsoft.ComponentDetection.Detectors/rust/RustCrateUtilities.cs?rgh-link-date=2022-08-31T21%3A09%3A35Z#L300-L318

Rust detector silently discards non-dev dependencies when `Cargo.toml` file contains dependency from git

@ByAgenT can you confirm if this is still happening in `v2.0.0` or newer? That version is the first to include the cargo rewrite from #117

Migrate from `Newtonsoft.Json` to `System.Text.Json`

@tevoina thanks for the pointers @pn04 based on the info Teo shared someone from the Microsoft side will likely have to pick this item up. Thank you for volunteering though...

Is there a way to have scan manifest printed to stdout ?

Not currently. We print a summary to stdout, but I can see why you'd want just the manifest. It means you don't have to mount a volume to the container.

Implement Roslyn Source Generator to generate from file in a project

@mio991 Could you open a PR with your changes?

Provide `Async` methods

Thanks for the explanation. Is this something you'd accept contributions for, or something you'd never accept into Tomlyn? If you'd never accept contributions for, I think you can close this...

Use HTTPS source for `aspell`

@Camelron I switched back from the GitHub mirror to `https://ftp.gnu.org`.