component-detection icon indicating copy to clipboard operation
component-detection copied to clipboard

Refactor: Fix warning SA1101

Open AdamPlaskitt opened this issue 3 years ago • 5 comments

Related to #202

Prefix local calls with this. https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1101.md

AdamPlaskitt avatar Aug 27 '22 18:08 AdamPlaskitt

CLA assistant check
All CLA requirements met.

ghost avatar Aug 27 '22 18:08 ghost

Thanks for the PR 😄

JamieMagee avatar Aug 28 '22 17:08 JamieMagee

@AdamPlaskitt the warnings in the build need to be fixed and then I can approve

amitla1 avatar Aug 30 '22 21:08 amitla1

@AdamPlaskitt the warnings in the build need to be fixed and then I can approve

Hey @amitla1, I can see any build warnings in the files I changed?

AdamPlaskitt avatar Sep 01 '22 19:09 AdamPlaskitt

@AdamPlaskitt the warnings in the build need to be fixed and then I can approve

Hey @amitla1, I can see any build warnings in the files I changed?

@AdamPlaskitt Yes it's not a file you changed but it's related to the fix for warning SA1101 that this branch was for: image

amitla1 avatar Sep 01 '22 20:09 amitla1

👋 Hi! It looks like you modified some files in the Detectors folder. You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

github-actions[bot] avatar Oct 05 '22 17:10 github-actions[bot]