Jamie

Results 51 comments of Jamie

Ok, https://github.com/Jamie5/rules_scala/commit/8724a32b45a7be02ec66aa64bb71fdd3d573fe9f#diff-3830e6e26d863974d38e511b04761916 has code for unused_deps as well. Notes - Strict deps check seems to work well generally speaking - With the test changes of adding error on unused deps,...

> Completely fine for POC. When we'll want to merge it we'll need to consider if it's ok or not. > Again for POC fine, for merge we'll need the...

@ittiaz just to make sure, you are not waiting for anything from me in order to test right? (want to make sure we are not both thinking we are waiting...

Will there be a way in the future to use both unused_deps and strict_deps at once? Currently readme suggests not

@ittaiz this happens to address https://github.com/bazelbuild/rules_scala/pull/1034 . Is it too early to stop running high-level transitive? If so I guess we'd have to leave this for a later point.

Hmm seems that would add more time to test running (not sure how much). So far not seeing any issues which would need to push removing the dependency_tracking_method past July...

@ittaiz what should we do here? My POV is probably skewed due to my former project, but we didn't use resources that much and when we did they were of...

Having this would be useful in adding tests for https://github.com/bazelbuild/rules_scala/issues/867 and I suspect useful in other situations as well. So would be great if we can get that. Should future...

@ittaiz do you happen to know if it's possible to specify deps for things using `maven_install` or if the best thing would be to re-export with deps specified or similar?

I think generally there are definitely issues where external dependencies don't declare their deps as deps (which @ittaiz I think you fixed some of). So there could be well another...