rules_scala
rules_scala copied to clipboard
Move transitive dependency mode tests to use ast dependency method
Description
We change the transitive dependency mode tests to use the ast dependency method.
This allows us to use an instance of unused_dependency_checker_ignored_targets which was needed to a deficiency in the high-level analyzer.
Motivation
As we are moving towards using the ast dependency method for transitive dependency mode, we wish to make the tests align with that. We also wish to not use unused_dependency_checker_ignored_targets
when not necessary.
@ittaiz this happens to address https://github.com/bazelbuild/rules_scala/pull/1034 .
Is it too early to stop running high-level transitive? If so I guess we'd have to leave this for a later point.
I feel it's too soon yeah. Maybe we should have these tests run both modes for now? Won't help with the unused_dependency_checker_ignored_targets but will give more inputs
Hmm seems that would add more time to test running (not sure how much). So far not seeing any issues which would need to push removing the dependency_tracking_method past July 30 so seems probably fine to wait until nearer to then.
closing as stale, feel free to reopen