Jamie

Results 51 comments of Jamie

I would want it on by default, because 99% of time running tests locally we're `fit` or `fdescribe`ing something and know there's thousands of unrun tests. And needing to explicitly...

Re 1, I don't think walking over the tree and finding used types would be very hard - the unused deps mechanism already does something similar (though they walk over...

Yes, agreed that 3 is better than nothing, even with the problem of non-strict deps. For 1, IME iterating over the tree as a plugin was not overly expensive (though...

Ah I see, I misread the code. It does seem to use the native java strict_deps but only for java files. Which does appear to iterate over the AST. Now...

Ok https://github.com/Jamie5/rules_scala/commit/cbba543c1e4a6c1174043d9dd5b4cd952bdc03b4 has a diff which is rather hacky (at least in terms of some plumbing) but does appear to do what we want. Run on a 2.12.8 codebase, some...

@ittaiz did you get a chance to look at this?

Sounds good, no worries I just never know if something is in someone's queue or got lost in the notification void.

One other random thought, if this works could a similar mechanism be used to not do plus one deps but examine only the ijar and determine which deps are actually...

@ittaiz did you get a chance to take a look?

I guess SCP-009 has not made much progress since? Because if it did and they can backport it to 2.12.x or even just 2.13.x then that would be great and...