James Newton-King

Results 94 issues of James Newton-King

## Failing Test(s) - Microsoft.AspNetCore.Components.E2ETest.Tests.ThreadingAppTest.NavMenuHighlightsCurrentLocation ## Error Message ```text System.AggregateException : One or more errors occurred. (Xunit.Sdk.NotEmptyException: Assert.NotEmpty() Failure at Xunit.Assert.NotEmpty(IEnumerable collection) in /_/src/xunit.assert/Asserts/CollectionAsserts.cs:line 502 at Microsoft.AspNetCore.E2ETesting.WaitAssert.c__DisplayClass18_0`1.b__0(IWebDriver _) in /home/vsts/work/1/s/src/Shared/E2ETesting/WaitAssert.cs:line...

test-failure
area-blazor

Create a sample that shows how to override recursion for protobuf with gRPC. Part of addressing https://github.com/grpc/grpc-dotnet/issues/1983

enhancement

A simple sample that includes code to detect wether the current platform supports grpc-dotnet. Support requirements: https://learn.microsoft.com/en-us/aspnet/core/grpc/supported-platforms?view=aspnetcore-7.0 Code should look at the .NET version (.NET Core 3 or later) and...

enhancement

Replicate current event counters as metrics. Investigate labels that can be added to make counters more useful.

enhancement

When a server shuts down it gives a grace period to requests to finish. However, there is no indication to requests that they should finish, i.e. `ServerCallContext.CancellationToken` isn't raised. To...

enhancement
docs

There are some tips for using Grpc.Tools that would help people if they were more widely known. For example: Import protos with wildcards: ```xml ``` Use ProtoRoot: ```xml Protos ```

docs

`AuthInterceptorContext` should probably have a cancellation token on it so any logic in the auth interceptor can respond to call cancellation, exceeded deadline or dispose.

kind/bug
lang/C#
priority/P2
api

.NET 8 added keyed services. Ensure DI on interceptors and services work with keyed services.

bug

Compression creates a stream on the server because compression APIs are stream based. e.g. https://github.com/grpc/grpc-dotnet/blob/1625f8942791c82d700802fc7278c543025f0fd3/src/Grpc.AspNetCore.Server/Internal/HttpContextSerializationContext.cs#L239-L248 Right now, a memory stream is created which can allocate a large buffer. We could...

enhancement

### Description [ASP.NET Core rate limiting middleware](https://learn.microsoft.com/aspnet/core/performance/rate-limit) is being updated in .NET 8 with extra functionality. The middleware now requires services registered with `AddRateLimiter`. ### Version .NET 8 Preview 5...

Breaking change
Documented
8.0.0