James Newton-King

Results 299 comments of James Newton-King

I'm not sure about this. Nothing in the JSONPath says that filters should apply to objects.

The reason I left JsonSerializer with a property that returns IReferenceResolver is the property can be used inside a JsonConverter's WriteJson/ReadJson (each has a JsonSerializer parameter). A func that returns...

Static configuration isn't a good idea. What happens if two libraries set it to different values? The right way to do this would be to have a settings object that...

This type isn't designed to have thread-safety. Even if the id was incremented with Interlocked, the underlying collections aren't thread-safe. And if the collections were made threadsafe then performance would...

What is the benefit of targeting netstandard2.1? As far as I know the netstandard2.0 assembly will work fine. I don't want to add an extra assembly and increase the package...

I don't like making internal methods public that aren't designed to be used publicly. Is there any reason you can't copy of the code from JsonSerializationException.Create and JsonPosition.FormatMessage, and throw...

I'm not sure about this. There are 3 other ASCII separators characters. Why not them as well? Why not semi-colons or fullstops? etc No delimiter makes sense to me, and...

I like what you're trying to do, it is common feedback that JSON for DU isn't what they expected. Two things: 1. Rather than introduce a new attribute I'd like...

Also DU's can have unnamed values. An exception should be thrown when attempting to serialize and deserialize them with this named DU mode.