James Newton-King

Results 646 comments of James Newton-King

Is the version of Aspire dashboard changing between app hosts? The only scenario we know of that causes this error is moving from one version to another.

Do you have a scenario where this change would be useful? > existing accessors should alloc if needed and update their fields to the new right-size copy, so repeated calls...

What's the scenario where you want to set activity tags on creation? This seems like kind of niche feature and I'd prefer to see whether the problem can be solved...

> This is to support using those tags when making sampling decisions as only tags provided in the CreateActivity/StartActivity are available at that time. Is the scenario that you set...

Right now tracing in ASP.NET Core doesn't follow the OTEL standard. When we do then those tags should be set immediately. It sounds like server address and port are what...

I don't want to add a new feature. I'd prefer that we followed what the standard proposes and makes the [here](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md?rgh-link-date=2025-05-26T15%3A14%3A28Z#:~:text=bots%20or%20tests.-,The%20following%20attributes%20can%20be%20important%20for%20making%20sampling%20decisions%20and%20SHOULD%20be%20provided%20at%20span%20creation%20time%20(if%20provided%20at%20all)%3A,-http.request.method) about including some tags at creation time. The problem...

@rkargMsft I took a look at your PR, how it interacts with OTEL libraries, and how it aligns with our long term goal to set OTEL attributes on this activity...

In case this change causes problems or we decide that it's undesirable to partially support OTEL spec, @rkargMsft what do you think of defaulting it to off and using the...

If it is working, you have security on endpoints, and you've set the options from https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/dashboard/configuration that are appropriate for your scenario then it sounds like you're done.