James Newton-King

Results 646 comments of James Newton-King

I haven't seen this situation be a problem myself (higher generated code than Google.Protobuf version). But that's probably because many people who build gRPC apps (not libraries) use generated code...

> My reasoning for validating this as early as possible in code terms is to prompt users as early as possible in development lifecycle terms. The cost of updating Google.Protobuf...

This is a bad rule: ```cs if (currentVersion.Major != targetVersion.Major) { throw new InvalidOperationException(GetErrorMessage("major")); } ``` Imagine: * NuGet package `Grpc.Reflection` has source gen code for 4.x.x. * NuGet package...

My thoughts here - https://github.com/protocolbuffers/protobuf/pull/10862#issuecomment-1308425758 - haven't changed. > but fundamentally that still would still leave us running with code written for one major version running against a different major...

Simple is good but it brings along its friend, inflexible. And inflexible + dependencies aren't a good combination. .NET Framework's simple but inflexible binding rules with strong named assemblies is...

FYI .NET 6 is end-of-life November 12, 2024 https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core

I think it's fine to have all the dashboard docker run commands expose both.

I think your problem is different assembly versions referenced. You probably need binding redirects: https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/redirect-assembly-versions