James Newton-King

Results 646 comments of James Newton-King

Implementing `AddSignalRInstrumentation()` might be as simple as calling `builder.AddActivitySource("Microsoft.AspNetCore.SignalR.Server")` internally. It would only be supported in .NET 9 and later.

HttpHandler doesn't have a good way to compose your settings with the default settings. What you're doing, creating a new SocketsHttpHandler and then setting everything on it, is the best...

The problem is a lot of these APIs are only available on certain HttpHandler implementations. What should happen if the handler doesn't support keep alive? Throw an error? Silently ignore...

@an3soft I think you're seeing a recent regression in 2.70.0: https://github.com/grpc/grpc-dotnet/issues/2612 Try downgrading to 2.67.0 and see whether the problem persists. A fix should come in 2.71.0.

2.71.0-pre1 is out. You could test with that. Non-preview version will come out a week later.

There are no changes that could impact performance. Any difference you are seeing is noise.

What about when you want to disable capturing but still have access to instance fields?