James Newton-King
James Newton-King
@Tratcher @halter73 Any more feedback on this PR? I'd like to merge it 🙏
The changed test error in this PR shows it works.
@eerhardt Part of publish size effort.
@eerhardt After making these changes locally, updating the assembly in the SDK folder, and republishing, I still see expressions related warnings. ``` /_/src/libraries/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/ArrayOperations.cs(23): AOT analysis warning IL3050: System.Linq.Expressions.Interpreter.NewArrayInitInstruction.Run(InterpretedFrame): Using member...
This doesn't fix the expressions AOT warnings, but IMO this change is still worthwhile. Invoking via raw reflection is better than interpreting compiled expressions. And this change is pretty modest,...
cc @halter73 @JeremyLikness
The first step is to figure out what the metrics are. The issue includes some notes from discussing metrics with @halter73 @JeremyLikness. I think they're the folks that need to...
Can you provide why you want to disable the metric? It is useful for us to understand why and when a new feature would be used.
`ShortCircuit()` skips middleware, but the counter is recorded at the hosting layer. It won't be skipped.