James Newton-King

Results 320 comments of James Newton-King

A TypeConverter will deserialize complex classes in keys.

There is different behavior because unlike classes, even a struct with a parameterized constructor will still have a default constructor, and so it will only be called if every parameter...

Done. I noticed at least one still in Newtonsoft.Json, but there is of course all the tests which will be another huge change.

This might be fixed here? https://github.com/JamesNK/Newtonsoft.Json/pull/2902

I don't think this feature is valuable. There is already a `JObject.Load(JsonReader reader, JsonLoadSettings? settings)` method that lets you customize the reader. Having a setting on JsonLoadSettings for max depth...

I couldn't replicate this in a test. See below. Also, I don't see how this error is possible. You can't get `DivideByZeroException` when dividing by a zero double. The result...

I need time to think this through and understand what breaking changes it could cause. I'm really busy right now, so I don't know when I'll get to that.

Doesn't your sample set MaxDepth to int.MaxValue? That basically removes the limit.

`$id` has a special meaning to Json.NET. Disable it with `MetadataPropertyHandling.Ignore`. https://www.newtonsoft.com/json/help/html/DeserializeMetadataPropertyHandling.htm

Dual licensing is normal and common - https://www.synopsys.com/blogs/software-security/software-licensing-decisions-consider-dual-licensing/ The question in the issue you linked is about someone who publish software as AGPL but prohibited it from being used by...