Jakub Hanko
Jakub Hanko
Hello, reviving an old thread. Changing `d_prevcost = CuArrays.CuArray{Cfloat}(n)` to `d_prevcost = CuArrays.CuArray{Cfloat}(undef, n)` in LSQ_GPU.jl:66 has done the job for me, apparently. Same change for `d_newcost`. Letting everyone know...
Sure, OS is Red Hat Enterprise Linux 8.6 and Kernel is Linux 4.18.0-372.19.1.el8_6.x86_64. I am using Julia 1.1.1. There was this wonky behavior when building Rayuela for the first time...
I got one more CUDA-related error on a custom dataset (100k x 4096) which I unfortunately cannot share so I will understand if you are unable to help here. ```...
Fixed here https://github.com/pagefaultgames/pokerogue/pull/742
> Should this also pass opponent in for abilities like Unaware? I have two questions since my Pokémon skills are rusty: 1. correct me if I am wrong but Unaware...
Decided to go with two classes, each dedicated to its respective move since both calculations are fairly specific to their use cases.
TSDocs have been added.
@DustinLin Thanks for the demo and the review. I cleaned up the nits. About the recording - I might do it during the weekend. The other moves follow the exactly...
Adding videos for the other two moves. https://github.com/pagefaultgames/pokerogue/assets/60473007/d99d7b27-45bc-4037-a1a4-2c70bbcacfa1 https://github.com/pagefaultgames/pokerogue/assets/60473007/e64fc237-56b1-48bf-b6b2-7d3508a80cf1
> Looks like there are conflicts on this currently > > Looking to get JSDoc documentation as shown here: [Code Comment FAQ](https://discord.com/channels/1125469663833370665/1239957703820836975) Added the docs, is it better now?