pokerogue Implement type immunity removal moves

The scope of this PR is to implement the following moves:

Odor Sleuth
Miracle Eye
Foresight

The goal is to make the evasiveness reset and type removal work.

May 13 '24 07:05 JakubHanko

Included a demo for odor sleuth, checking to make sure everything works, it would be great if the author does something similar for the rest that they implemented

https://github.com/pagefaultgames/pokerogue/assets/39450497/2ecfe207-de48-45ff-9c60-5778effc758b

May 16 '24 19:05 DustinLin

@DustinLin Thanks for the demo and the review. I cleaned up the nits.

About the recording - I might do it during the weekend. The other moves follow the exactly same logic as Odor Sleuth though. If one works, all should.

EDIT: Never mind - the imports got scrambled during the merge. Will fix that tomorrow.

May 16 '24 20:05 JakubHanko

Adding videos for the other two moves.

https://github.com/pagefaultgames/pokerogue/assets/60473007/d99d7b27-45bc-4037-a1a4-2c70bbcacfa1

https://github.com/pagefaultgames/pokerogue/assets/60473007/e64fc237-56b1-48bf-b6b2-7d3508a80cf1

May 18 '24 06:05 JakubHanko

Looks like there are conflicts on this currently

Looking to get JSDoc documentation as shown here: Code Comment FAQ

Added the docs, is it better now?

May 19 '24 18:05 JakubHanko

Can we get a video of the same scenarios from the original comment to show that evasion no longer gets reset?

May 26 '24 08:05 bennybroseph

https://github.com/pagefaultgames/pokerogue/assets/60473007/27895635-c127-4b5c-a3a1-c6ad81c128a1

Here is a video of Odor Sleuth. Are the other two videos necessary? They all follow the same logic. Either all work or none.

May 26 '24 14:05 JakubHanko

For the most part, these moves are working correctly, evasion and types are being ignored.

But going over some edge cases, mainly Wonder Guard and Mind's Eye (basically same functionality as Odor/Foresight):

Mind's eye allows hitting through Wonder Guard with a fighting type move:

https://github.com/pagefaultgames/pokerogue/assets/171270136/87187c27-0048-4280-99de-a8903c898393

However, after using foresight i can't hit it anymore:

https://github.com/pagefaultgames/pokerogue/assets/171270136/480cf340-bce5-4006-abd2-d26e02e13e4b

And just in case here's Wonder Guard vs just Foresight:

https://github.com/pagefaultgames/pokerogue/assets/171270136/8ada1340-548e-4f2e-88a5-b4ffe8b9c496

Unsure how this interaction is supposed to go, but in theory both Mind's Eye and Foresight should have the same result vs wonder guard. And why does Odor/Foresight make Mind's Eye stop working.