Jake Wharton
Jake Wharton
Presumably because we don't support injecting a `MembersInjector`.
While that's true, this still should work in reflection since we don't actually need to resolve that `T`. The implementation injects a `Map>` which the generated module binds into using...
This is a problem with generic handling. We don't correctly project `T` to be your application subtype. There's a few other issues for this.
Yeah I believe this is causing https://github.com/JakeWharton/dagger-reflect/blob/6ab4adefb67c315e49e303c973bab557b213afa7/integration-tests/upstream/build.gradle#L76-L77 and maybe even some of the failures above that as well.
In general it looks fine. You need to run Google Java Format task to reformat code. Are you able to add a test case?
Yes. It's actually supposed to be set up to guard against this already...
Thanks. I'll look soon. Although I'd be happy to land this as-is and fix that separately as a bug.
When I wrote them I was inspecting the classfile output of both tools and both looked correct. On Thu, Jul 18, 2019 at 1:22 PM Laimonas Turauskas wrote: > Using...
I haven't had time to look at it yet so I don't even know what's crashing. On Thu, Jul 18, 2019 at 2:26 PM Laimonas Turauskas wrote: > Any ideas...
Seems like you should file this against the tools and see what they say first? I'm not sure there's a whole lot we can do here except for caching nothing...