Jake Wharton

Results 1654 comments of Jake Wharton

Ah yep. I just mentioned the four-person family one on the other issue which is the one I always think of. I think there's stuff with flags now, too. It...

![Screen Shot 2022-02-23 at 1 55 28 PM](https://user-images.githubusercontent.com/66577/155388067-9e0bed4f-6ebf-4f15-bdfb-5a6a92b63af4.png)

Hmm yeah I missed that. I was more thinking of the variant selection code point and things like when you combine four people into a family emoji.

We have a bunch of ignored functional tests for the same reason: ```groovy // TODO reflect-compiler bug! Not generating builder method. exclude 'dagger/functional/builder/BuilderTest.java' exclude 'dagger/functional/cycle/DoubleCheckCycleTest.java' exclude 'dagger/functional/membersinject/MembersInjectionOrderingTest.java' exclude 'dagger/functional/nullables/NullabilityTest.java' exclude...

It will be a while until I have time to work on this. If anyone wants to do any work in a PR it would be welcomed.

I have no intention of building support for it. If it's even possible to support then PRs are welcome. On Sat, Jul 4, 2020, at 8:49 PM, Róbert Papp wrote:...

A bunch of the Dagger functional tests cover this and are currently muted. Hope to get to it eventually, but it's probably non-trivial.

The support of generics is lacking. There's also #135 tracking its support on modules.

Both will be changes to `ReflectiveModuleParser`. The easiest way to get started is to get a failing test case in the integration tests that passes on the codegen backend. Then...

You don't have to, there's already an annotation processor which generates bridges into the reflection code. #2 would also solve this if you're using Kotlin