Jake Wharton

Results 1651 comments of Jake Wharton

You need to de-obfuscate the stacktrace and tell us which version, first.

``` AwaitSignalTest_Async[jvm] > signaled[jvm] FAILED java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:685) at okio.AwaitSignalTest.assertElapsed(AwaitSignalTest.kt:202) at okio.AwaitSignalTest.access$assertElapsed(AwaitSignalTest.kt:31) at okio.AwaitSignalTest$signaled$SignaledTestFunction.invoke(AwaitSignalTest.kt:51) at okio.AwaitSignalTest_Async$intercept$CallSuperTestFunction.invoke(AwaitSignalTest.kt:31) at okio.AwaitSignalTest$intercept$ExecutorServiceTestFunction.invoke(AwaitSignalTest.kt:31) at okio.TestExecutor.intercept(TestExecutor.kt:48) at...

``` okio.PipeTest[jvm] > sinkBlocksOnSlowReader[jvm] FAILED java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:685) at okio.PipeTest.assertElapsed(PipeTest.kt:356) at okio.PipeTest.sinkBlocksOnSlowReader(PipeTest.kt:171) ```

Again https://github.com/square/okio/actions/runs/11182275912/job/31088199790?pr=1529

Again https://github.com/square/okio/actions/runs/11334093069/job/31519563616

Again https://github.com/square/okio/actions/runs/11391218746/job/31694519307

I have a related use case here: https://github.com/JakeWharton/finalization-hook/. My motivation was actually less in safe coroutine cancellation and more in resetting state externalized from the process. For this reason it...

Their need to use thread locals is because they operate directly on subject values whereas here we have the benefit of a wrapper type to carry along information. There's already...

I wasn't saying that you need to carry it to the leaf. I was saying that this is already supported with the path-like naming mechanism that's built in, but it...

Yes that is currently thread-local based, but I have a proposal (that I've been sitting on for too long) for changing it to be instance-based. That would improve the ability...