Jake Wharton comments

Results 1654 comments of


                                            Jake Wharton

JS optimized implementation of ProtocolWidget and ProtocolState

Is this done?

Generate JS. Compatible with HarmonyOS

So what's the problem? The error message doesn't tell us anything.

Build Error: java.lang.NoSuchMethodError: void org.jetbrains.kotlin.ir.symbols.impl.IrSimpleFunctionSymbolImpl.<init>

With what version?

Generate abstract class which does mutable state binding for Compose UI

So the design in #2749 ends up using composable lambda functions, but this incurs boxing. So we need to change it to maybe ```kotlin abstract class AbstractComposeUiButton : Button Unit>...

Generate abstract class which does mutable state binding for Compose UI

I updated to a list of abstract functions on an abstract base type for now.

Generate abstract class which does mutable state binding for Compose UI

Need to migrate existing bindings to use this

Disable Android release unit test tasks by default

AGP 9 does this by default. Hey! Let's just update.

Split `Widget` responsibility into `Binding` and `NewWidget`

Definitely struggling to make this work as a simple change. It may be worth combining `NewWidget` into `WidgetNode` as the tree type, where that type becomes the tree node. However,...

Support Android Kotlin Multiplatform SQLite drivers

You can use https://github.com/eygraber/sqldelight-androidx-driver for a version of our driver that delegates to their driver abstraction. Then you can plug in any of those three listed implementations of their driver...

Add a SqlDriver for Androidx SQLiteDriver

> Once I'm here, [this line from AndroidSqliteDriver](https://github.com/cashapp/sqldelight/blob/master/drivers/android-driver/src/main/java/app/cash/sqldelight/driver/android/AndroidSqliteDriver.kt#L172) tripped me up. I can't figure out in what scenario the previous connection should be closed, because if `identifier != null` then...