JakeQZ

Results 217 comments of JakeQZ

> What do you think? I think that makes sense (though I don't know what the 'risky rules' are offhand). Edit: oh, I see the 'risky rules' relate to migration...

> The only similar thing that was decided was deprecating and removing the expansion of shorthand properties. Ridiculously, this would have been potentially useful to the sister project, [Emogrifier](https://github.com/MyIntervals/emogrifier). Is...

As I understand, these mimick PHP's inbuilt functions, but are adapted to observe the `@charset` of the CSS. Though `substr` is a bit different and works on the entire CSS...

We're talking about class dependencies, rather than object dependencies. A linked-list in C++ (before stdlib) would have loops in the objects, but they would all be of the same class....

We would need to change the various `render` methods to take an `OutputFormatter` argument instead of an `OutputFormat`. To begin with, they would need to be able to accept either,...

We should probably use `~` version in the PHIVE config, so that contributors don't pick up breaking changes.

> `composer-normalize` seems to throw a false error: 'Your Composer dependencies require a PHP version ">= 7.4.0"'. The message is misleading, since we install `composer-normalize` via PHIVE. `composer-normalize` does not...

We can't use the `Safe` version of `preg_replace_callback` universally until we have PHP 8.1 as a minimum version. It was [added late to the library](https://github.com/thecodingmachine/safe/issues/223) and [not included until the...

> > It might be worth our adding a `Pelago\Emogrifier\preg_replace_callback()` function in the meantime to handle the situation, so that the main code isn't cluttered with `function_exists()` tests. WDYT? >...

> I don't know how Composer autoloading would works for functions instead of classes. Do you have any experience with that? Me neither. But the `Safe` library manages it, so...