JakeQZ
JakeQZ
We could also make the `$mediaQuery` parameter of the constructor optional.
Would be good to resolve #1247 before moving on with this.
This is almost ready for review, but some tests need to be added. Before doing so, I'd appreciate a pre-review from you: @sabberworm, @oliverklee. I'm not keen on the having...
> Maybe as another spin-off PR (or prepatch), we can introduce the interface and have one class implement it. #1256.
I think all pre-PRs that can be separated have been completed now.
> This PR needs a rebase. It is impossible to rebase now, because git does it one commit at a time, and I probably included changes in the wrong commits...
I tried undoing lastest merge, but it's still a mess. I can't even get back to where I was now. Will take some time redoing.
> > I tried undoing lastest merge, but it's still a mess. I can't even get back to where I was now. Will take some time redoing. > > In...
> If I could somehow reset the branch to the state it was in immediately after the commit "Reorder construction" ```cmd git reset -hard {SHA-of-last-commit-before-attempted-rebase} ``` ... undid the failed...
I think this is now ready for a final review.