MyIntervals
Dependency loop `OutputFormat`/`OutputFormatter`
Both have references to an instance of each other. Dependencies should go only one way, though, and loops are a really bad thing.
We're talking about class dependencies, rather than object dependencies. A linked-list in C++ (before stdlib) would have loops in the objects, but they would all be of the same class.
As I understand, OutputFormat is where the settings are, and OutputFormatter is the worker. So OutputFormatter should have a reference to OutputFormat, but there shouldn't be a need for one the other way.
We would need to change the various render methods to take an OutputFormatter argument instead of an OutputFormat. To begin with, they would need to be able to accept either, with the latter deprecated. I'm assuming there's already an easy means for users to create an OutputFormatter from an OutputFormat. If we tread this path, it means we can't mark OutputFormatter as @internal. Thoughts welcome...