Jake Champion
Jake Champion
I see this has been labelled es5. I figure I should mention that BigInt was added in es2020, which is the 11th edition and not in es5. Not sure if...
@sussexrick - I have a pull-request which fixes the `aria-activedescendant=false` issue --> https://github.com/alphagov/accessible-autocomplete/pull/497
@sussexrick, we have forked accessible-autocomplete and added a few bug fixes such as this one. We published our fork to `@financial-times/accessible-autocomplete`, the [changelogs from v2.1.0 onwards](https://github.com/Financial-Times/accessible-autocomplete/blob/master/CHANGELOG.md#210---2021-05-24) are the changes we've...
This looks to solve the same issue as https://github.com/alphagov/accessible-autocomplete/pull/491 - is that right?
There are a couple of other places where inline styles are being used: - https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/autocomplete.js#L528 - https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/wrapper.js#L56 @lennym, would you want these to have a class-name defined as well?
Another good use-case I have come across for returning the component from the wrapper module: https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/wrapper.js#L4 We wanted to implement a button to clear and re-focus the input field, this...
There is a potential bug for using async right now, below is the steps to show the issue: 1. Create accessible-autocomplete instance with an async source function 2. Type a...
Nice work @ExE-Boss ☺️
versions in the range `^9.0.0` are also experiencing this issue.
I've been adding this to the top of my jest test files and it works great: ```js const esmImport = require('esm')(module); const moduleBeingTested = esmImport('../src/module'); ``` E.G. ```js // ./src/add.js...