Jake Champion

Results 156 comments of Jake Champion

Red boxes captured instead of imagery

Sketch 62 worked for me 👍

fetch response body as ReadableStream

@ritikBhandari yes you can 👍

this.append is not a function

Sure thing @KVROHITH098 - I'm happy to review a PR for this

fix: ignore not throw on invalid response headers

`_http_outgoing.js` is part of the [built-in NodeJS http module](https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js), it is not possible to set a response header name in an invalid format with the built-in NodeJS http module. The...

normalizeName should not throw

@pke, could you post an example of the response header which was causing the error to be thrown please?

normalizeName should not throw

@pke I am having a hard time replicating the issue, mainly because I can not build a server which creates a header name containing spaces. Could you create a server...

normalizeName should not throw

Thanks @milgner. Firefox's native fetch does not error and instead ignores the header, I tested this by going to http://cronos.illunis.net:1337 and running this in the browser console: ```js fetch.toString() response...

normalizeName should not throw

@pke, If you are happy to submit a pull-request which changes this to a `console.warn` as you originally suggested, I would accept it and release the change to npm 👍

normalizeName should not throw

@pke of course. The line which calls parseHeaders is this one: https://github.com/github/fetch/blob/8f48ca686f9564bf52704e0e4b410ca970b17031/fetch.js#L518

readBlobAsText does not repect the reponse charset

Hi, no, it is still maintained