accessible-autocomplete icon indicating copy to clipboard operation
accessible-autocomplete copied to clipboard

Add className attribute to status component

Open lennym opened this issue 3 years ago • 2 comments

The status component is currently hidden from view using inline CSS, however in an implementation that applies aggressive CSP controls these styles cannot be applied, and since the status element has minimal other identifying attributes, it is difficult to apply corresponding styles in .css files.

Apply a class attribute to the status component - defaulting to autocomplete__status so that it can be reliably targeted by CSS selectors.

lennym avatar Jul 06 '20 09:07 lennym

There are a couple of other places where inline styles are being used:

  • https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/autocomplete.js#L528
  • https://github.com/alphagov/accessible-autocomplete/blob/935f0d43aea1c606e6b38985e3fe7049ddbe98be/src/wrapper.js#L56

@lennym, would you want these to have a class-name defined as well?

JakeChampion avatar Jun 28 '21 14:06 JakeChampion

To be honest, this is a year old and so the problem I was trying to solve has long since left my memory.

Feel free to use your judgement as to what you think is best.

lennym avatar Jun 28 '21 14:06 lennym

@lennym Thanks for adding this. Seems the branch needs a little rebase and for dist to be rebuilt. Given your last comment hinting that it had been a while since it was open (and even longer since 😬 ), would you prefer I take care of that (force pushing on your branch, or starting a new PR from a copy of your branch, depending on what GitHub's permissions allow me)?

romaricpascal avatar Jan 12 '24 11:01 romaricpascal

My previous comment still stands... I haven't used this module in literally years, and probably won't in the foreseeable future.

Do as you see fit.

lennym avatar Jan 12 '24 11:01 lennym

Closing as I've had to create a new branch I could push to. The contents of this PR will be merged by #620.

romaricpascal avatar Jan 12 '24 11:01 romaricpascal