Michał Jadwiszczak
Michał Jadwiszczak
> @Jadw1 I got a glimpse of it and it looks like it is going in the right direction, are the unit test failures expected or did they discover a...
V2 changelog: - Extended snapshot transfer to include service levels mutations. I've put it in `raft_topology_snapshot` and service levels are not a topology thing but now there is no other...
V3 changelog: Addressed most of the comments. I've resolved the obvious ones and commented on other updated. I didn't look into failed test yet. Also I need to add a...
V4 changelog: - now group0_guard is obtained from cql statement instead of by service level controller itself - using abort_source correctly - fixed failing tests - improved service levels snapshot...
v5 & v6 changelog: - addressed comments - rebased on top of https://github.com/scylladb/scylladb/pull/16578 (removed copied commits, moved `test_raft_service_levels` to `auth_cluster` suite) - fixed tests - reads with raft service levels...
v7 changelog: - dropping a service level also removes it from roles' attributes. Because now both auth and SL are on raft, this has to happen on the same group0...
v8 changelog: - moved service levels mutations from `raft_topology_snapshot` to `raft_snapshot` - fixed tests > #### 🔴 CI State: FAILURE > ✅ - [Build](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/7178/) ✅ - [Container Test](https://jenkins.scylladb.com/job/scylla-master/job/scylla-ci/7178/) ✅ -...
v8 changelog: - dropping service level: Now it executed 2 raft commands, firstly removes attributes from roles, then the service levels is dropped. I'll leave it for @nuivall to fix...
Changelog: - `get_all_referenced_user_types()` utility function Followed @piodul suggestion and made visitor stateful. Also I've moved the method from `abstract_type` to `user_type`, as it's only used by UDTs. Extended comment in...
Changelog: - changed sorting function to use `user_type` instead of `sstring` in map and vector - Improved comments in sorting function, I've tried to made them more explanatory as @piodul...