Michał Jadwiszczak

Results 57 comments of Michał Jadwiszczak

Changelog: - addressed Nadav comments: added sanity checks, extended comments, looking for `keys(` prefix instead of checking if string contains `keys` substring (in describe_index_columns method)

Changelog: - fixed the mistake in the test

Please take a closer look at https://github.com/scylladb/scylladb/pull/18758/commits/dc131033065dd5d64c021aaf5d5ce584f7a22c30: > service/qos/service_level_controller: add a method to reload configuration > > Instead of updating service level configuration in a loop, > the method schedules...

Changelog: - addressed commens (mostly comments, some small style/code improvements, no logic change) - rebased on latest masters

Changelog: - the update loop now is started when: the feature is not enabled or cluster is in recovery mode or migrate to raft topology hasn't been done yet -...

Changelog: Rebased on latest master with merged https://github.com/scylladb/scylladb/pull/17910, which introduced `group0_batch`. Dropped a new raft command type `service_level_change` and related feature. Instead, added a methods to look through table ids...

Changelog: - fixed bug which caused the failing tests - updated `write_mutations` description - changed `modules_to_update` in `group0_state_machine` to be struct of bools - addressed rest of comments - improved...

Changelog: - removed commit with catching broken semaphore exception and moved semaphore breaking to stop()