Jacob Oaks

Results 18 comments of Jacob Oaks

Thanks for reporting this, this looks like a bug. I'll investigate. Internal ref: GO-2096.

Hey @paullen - sorry for the delayed response. This is a legitimate issue we should fix, but we are still thinking about the right way to go about it, since...

Hey @screwyprof, I think @abhinav is actually suggesting (correct me if I'm wrong) a modification to Fx where Fx will provide the `RunningApp` (name WIP) type for you, similar to...

I do think that this would be a useful check to add, but my concerns are: * I don't think it is necessarily invalid to have an empty value group,...

Hi @wuyinq, it seems like the compressed files you're referring to are coming from a lumberjack Logger. Zap doesn't have any control over what lumberjack is writing to disk. I'd...

Hey @arukiidou - my understanding is that the go line in a library's go.mod file now sets a requirement for all consumers of the library, so I actually think we...

Hey @arukiidou - * For zaplog, is not upgrading zap blocking usage (and eventual merging) of zapslog? The advantage of upgrading here is that we can get rid of some...

Hey @adrianlungu, thanks for the PR. As it stands currently, this is a breaking change. Adding a method to an exported interface will cause all custom implementations to no longer...