zap
zap copied to clipboard
Upgrade go version to 1.21 in go.mod
I upgraded go version to 1.21 in go.mod. copy of #1181
- see: #1181
- passed test: https://github.com/arukiidou/zap/pull/8
Hey @arukiidou - my understanding is that the go line in a library's go.mod file now sets a requirement for all consumers of the library, so I actually think we may want to be more conservative when it comes to updating it so as to not require all consumers to upgrade, unless there's a very good reason. But I'm open to other thoughts!
Yes, it will need to upgrade most of go.mods to pass the test.
Why upgrades?
- zapslog is approaching move to core. but, zapslog requires go 1.21.
- According to the readme, zap may only support go 1.21 or later.
You make a good point , could postpone this for several months.
Hey @arukiidou -
- For zaplog, is not upgrading zap blocking usage (and eventual merging) of zapslog? The advantage of upgrading here is that we can get rid of some of the build tags, but my understanding is that it can still be used as long as the consumer of zap is using >= 1.21.
- It's true that Zap only officially supports the latest two versions, but upgrading go.mod makes it a hard requirement, rather than a suggestion.
If it's ok with you, I think we should probably wait on this.
Ok, I understood that this is still early.
Please let me know when the time comes.
@JacobOaks One more version progressed since then. Can I take this up again?