Jakub Kuczys
Jakub Kuczys
This should probably support the new `delete_message_seconds` rather than just the day count *but* the specifics of how this should be approached depend at least partially on #5922 so I...
#5947 is now merged, this PR still needs updates to the used wording. It's been settled in #5947 so it's just a matter of making it consistent with what we...
Damn, conflict with 4 files 😄 I will do it tomorrow as I'm a bit busy tonight, thanks for letting me know!
@DanielNoord Okay so I resolved conflicts and made it so `broad-exception-raised` also uses configured `overgeneral_exceptions` value (as opposed to the previously used constant; this is a not yet released check...
@DanielNoord alright, tests are now passing and unless you have further feedback, this should be good to go. The failure from 3.10 primer seems to be unrelated.
`broad-exception-caught` doesn't get triggered if the except block raises so these test additions don't seem to make sense
> `broad-exception-caught` doesn't get triggered if the except block raises so these test additions don't seem to make sense We could add few more try except blocks which ensure that...
> I'm concerned about the changes shown in the primer. Most of the patterns there look benign, where a broad exception is caught, and then some logging/cleanup is done, and...
All good, I'm happy you/primer caught it before this PR was merged :)
> UPlay is now supported Correct me if I'm wrong - you can play games that require Ubisoft Connect Launcher but unlike with Epic Games/GOG/Amazon Games, Heroic is not a...