Jakub Kuczys

Results 169 comments of Jakub Kuczys

> Are any PRs aside from #5924 blocking this? Until today, `pycares` release soft-blocked this PR as there was no release with 3.11 wheels for macOS arm64. That has been...

Ready for review. Install instructions tests pass in CI, I looked through changelogs of the updated dependencies, as well as the deprecations and removals in Python 3.10 and 3.11 changelogs....

Addressed the review, I've done one unrelated change to a message in redbot-setup failure mentioning running as admin because it bothered me: [`85a4c47` (#5674)](https://github.com/Cog-Creators/Red-DiscordBot/pull/5674/commits/85a4c477fc6ba9720b0e1375a7bdc19459e752d6)

Thanks for your contribution but currently we are not interested in this change.

I agree that the shown scenario is one of the cases that can produce this bug. It is possible that there will need to be some additional care taken since...

I think it makes no sense to not send any message at all, it's bad UX. User should always be getting some response and at the last resort (unexpected exception)...

JSON schema url can be specified with a top-level `$schema` key (to be explicit rather than rely on editor's auto-detection). However, Trivia cog will currently reject this as it expects...

This should probably just require adding this line to the `TRIVIA_LIST_SCHEMA` dictionary: ``` Optional("$schema"): And(str, error=_("{key} key must be a text value.")), ```

> In addition to the review comments, it seems that the default values are still in the property descriptions, they should be removed from there as well. Unsure if you...

Another worthy test case checking for proper inference of types when `self` is annotated as `Type[T]`: ```py from typing import Any, Optional, Union, Type, TypeVar, TYPE_CHECKING, overload T = TypeVar("T")...