Jerome Tremblay

Results 9 comments of Jerome Tremblay

Agreed. `text_chunker` make sense, there is also #404 referring to extend the chunker, good idea to align on this terminology.

@awharrison-28 Great! I did the renaming of the terminology (files, functions) partition -> chunk. Do you think I should also move the `text_chunker` in a different package than `semantic_kernel.semantic_functions` ?...

@awharrison-28 Thanks! updated. btw there's the same linting error than my other PR with those files : ``` would reformat /home/runner/work/semantic-kernel/semantic-kernel/python/semantic_kernel/kernel.py would reformat /home/runner/work/semantic-kernel/semantic-kernel/python/tests/end-to-end/basics.py would reformat /home/runner/work/semantic-kernel/semantic-kernel/python/tests/unit/orchestration/test_context_variables.py ``` I can...

> @JTremb do you know what more needs to be done here to get this in? We'd love to have it! @alexchaomander currently there's only 1 app supported (book-creator-webapp-react) the...

> @JTremb Can you lay out which skills are missing? I think we can first get this in and then add the necessary skills over time. Missing skills for each...

I have a basic version, it's currently missing the planner endpoint but with the new release I can implement and share !

I had similar issue today , can you try adding a return type hint ? e.g. ```python def extract_json_block_from_text(self, text: str): -> str ```

Looking a bit more at this. When there is no return type it infers a `DelegateTypes.Void`. - It would probably be better to raise an exception in this case and...

I have the same issue, but on my side it seems to be related to `opentelemetry` in my code if I switch from `semantic-kernel==1.7.0` to any version from `semantic-kernel==1.8.0` and...